Skip to content

Spacing fixes on OnboardingGeneral component #4891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2024
Merged

Spacing fixes on OnboardingGeneral component #4891

merged 1 commit into from
Oct 2, 2024
+12 −12

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Oct 2, 2024 •
edited by pr-codex bot
Loading

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR refactors the layout of the OnboardingGeneral and AccountForm components by replacing FocusLock and Flex components with div elements, adjusting the structure and styles for better flexibility.

Detailed summary

  • Replaced <FocusLock> with <div> in OnboardingGeneral.
  • Changed <Flex> to <div className="flex flex-col gap-4"> in OnboardingGeneral.
  • Updated layout classes in AccountForm, changing <Flex> to <div> with adjusted class names.
  • Removed unnecessary props and simplified component structures.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 6:55pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 2, 2024 6:55pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 2, 2024 6:55pm
wallet-ui ⬜️ Skipped (Inspect) Oct 2, 2024 6:55pm

@changeset-bot
Copy link

changeset-bot bot commented Oct 2, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: eb8638e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – docs-v2 October 2, 2024 18:19 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 2, 2024 18:19 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 2, 2024 18:19 Inactive
@MananTank MananTank marked this pull request as ready for review October 2, 2024 18:19
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 2, 2024
@MananTank Graphite App
Copy link
Member Author

MananTank commented Oct 2, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@codecov
Copy link

codecov bot commented Oct 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.60%. Comparing base (a6f85ac) to head (eb8638e).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4891   +/-   ##
=======================================
  Coverage   47.60%   47.60%           
=======================================
  Files        1054     1054           
  Lines       57164    57164           
  Branches     3917     3917           
=======================================
  Hits        27212    27212           
  Misses      29263    29263           
  Partials      689      689
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from a6f85ac
packages 43.35% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 41.95 KB (0%) 840 ms (0%) 2.2 s (-13.22% 🔽) 3 s
thirdweb (cjs) 101.7 KB (0%) 2.1 s (0%) 5.2 s (+10.17% 🔺) 7.3 s
thirdweb (minimal + tree-shaking) 4.82 KB (0%) 97 ms (0%) 380 ms (+173.76% 🔺) 476 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 109 ms (+76.28% 🔺) 119 ms
thirdweb/react (minimal + tree-shaking) 16.74 KB (0%) 335 ms (0%) 497 ms (+48.58% 🔺) 832 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 2, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 2, 2024 •
edited
Loading

Merge activity

@MananTank
Spacing fixes on OnboardingGeneral component (#4891)
eb8638e 
## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on refactoring the layout of the `OnboardingGeneral` and `AccountForm` components by replacing `FocusLock` and `Flex` components with `div` elements, enhancing the structure and styling of the components.

### Detailed summary
- Replaced `<FocusLock>` with `<div>` in `OnboardingGeneral`.
- Changed `<Flex>` to `<div className="flex flex-col gap-4">` in `OnboardingGeneral`.
- Updated `<Flex>` to `<div className={cn("flex w-full", ...)}> ` in `AccountForm`.
- Modified closing tags from `</Flex>` to `</div>` in both components.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@jnsdls jnsdls force-pushed the 10-02-spacing_fixes_on_onboardinggeneral_component branch from 574e36b to eb8638e Compare October 2, 2024 18:45
This was referenced Oct 2, 2024
Merged
Merged
@graphite-app graphite-app bot merged commit eb8638e into main Oct 2, 2024
27 checks passed
@graphite-app graphite-app bot deleted the 10-02-spacing_fixes_on_onboardinggeneral_component branch October 2, 2024 18:56
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 2, 2024 18:56 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 October 2, 2024 18:56 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui October 2, 2024 18:56 Inactive
@MananTank MananTank mentioned this pull request Oct 2, 2024
Merged
@MananTank MananTank mentioned this pull request Oct 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls jnsdls approved these changes

@joaquim-verges joaquim-verges Awaiting requested review from joaquim-verges

Assignees

No one assigned

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MananTank @jnsdls